[INS-467] Add IPinfo detector to default detectors list#4970
Open
mustansir14 wants to merge 1 commit into
Open
[INS-467] Add IPinfo detector to default detectors list#4970mustansir14 wants to merge 1 commit into
mustansir14 wants to merge 1 commit into
Conversation
Corpora Test ResultsNo detector regex or keyword changes in this PR. Bench skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
IPinfodetector to the default detectors list.Testing:
Unit Tests are passing. Integration tests didn't have the required keys in the GCP vault. Once added, they are passing too.
Corpora Testing:
The detector does not appear in the list.

Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Adding
ipinfoto the default detector set can change scan results and may increase verification traffic to the IPinfo API when verification is enabled, impacting runtime/false positives for some users.Overview
Enables IPinfo scanning by default by registering
&ipinfo.Scanner{}inpkg/engine/defaults/defaults.goand removingDetectorType_IPInfofrom the exclusions list indefaults_test.go.Updates the IPinfo integration test to assert
SecretPartsis populated and to ignore new/deriveddetectors.Resultfields (primarySecret,SecretParts) when diffing expected results.Reviewed by Cursor Bugbot for commit cda3c7c. Bugbot is set up for automated code reviews on this repo. Configure here.