Skip to content

[INS-467] Add IPinfo detector to default detectors list#4970

Open
mustansir14 wants to merge 1 commit into
mainfrom
ins-467-add-ipinfo-detector-to-default-detectors
Open

[INS-467] Add IPinfo detector to default detectors list#4970
mustansir14 wants to merge 1 commit into
mainfrom
ins-467-add-ipinfo-detector-to-default-detectors

Conversation

@mustansir14
Copy link
Copy Markdown
Contributor

@mustansir14 mustansir14 commented May 18, 2026

Description:

This PR adds the IPinfo detector to the default detectors list.

Testing:

Unit Tests are passing. Integration tests didn't have the required keys in the GCP vault. Once added, they are passing too.

Corpora Testing:

The detector does not appear in the list.
image

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note

Medium Risk
Adding ipinfo to the default detector set can change scan results and may increase verification traffic to the IPinfo API when verification is enabled, impacting runtime/false positives for some users.

Overview
Enables IPinfo scanning by default by registering &ipinfo.Scanner{} in pkg/engine/defaults/defaults.go and removing DetectorType_IPInfo from the exclusions list in defaults_test.go.

Updates the IPinfo integration test to assert SecretParts is populated and to ignore new/derived detectors.Result fields (primarySecret, SecretParts) when diffing expected results.

Reviewed by Cursor Bugbot for commit cda3c7c. Bugbot is set up for automated code reviews on this repo. Configure here.

@mustansir14 mustansir14 requested a review from a team May 18, 2026 08:48
@mustansir14 mustansir14 requested a review from a team as a code owner May 18, 2026 08:48
@github-actions
Copy link
Copy Markdown

Corpora Test Results

No detector regex or keyword changes in this PR. Bench skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant