Skip to content

Refresh docs/options.md to track remaining bindgen option cleanup#4446

Merged
kennykerr merged 2 commits into
masterfrom
copilot/reevaluate-options-documentation
May 20, 2026
Merged

Refresh docs/options.md to track remaining bindgen option cleanup#4446
kennykerr merged 2 commits into
masterfrom
copilot/reevaluate-options-documentation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

  • Audit current windows-bindgen CLI/builder options against docs/options.md
  • Confirm "Already landed" items match code
  • Confirm no listed options are now nonexistent
  • Refresh docs/options.md (first pass)
  • Implement §3 proposed option set:
    • Add public DepMode { Core, Specific, None } enum
    • Replace Bindgen::no_deps()/specific_deps() with Bindgen::deps(DepMode)
    • Replace Bindgen::sys_fn_extern() with Bindgen::extern_fns()
    • CLI: replace --no-deps/--specific-deps with --deps <core|specific|none> and --sys-fn-extern with --extern
    • Parse-time validation: reject --no-toml without --package and --extern without --sys
  • Update internal callers (fixtures.rs, fixture .tomls, samples, tests, crates/tools/bindings/*.txt)
  • Regenerate bindings via cargo run -p tool_bindings --release (no diff)
  • Run cargo fmt --all, cargo clippy -p windows-bindgen --all-targets, cargo test -p test_bindgen --test fixtures, cargo check --all-targets
  • Remove §3 (and obsolete §4/§5/§6 plan sections) from docs/options.md; fold migration table into "Already landed"

@kennykerr kennykerr marked this pull request as ready for review May 20, 2026 17:57
@kennykerr kennykerr merged commit ad92ae4 into master May 20, 2026
29 checks passed
@kennykerr kennykerr deleted the copilot/reevaluate-options-documentation branch May 20, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants