Skip to content

Fix missing icons for role assignment scope nodes under User Assigned Identities#5020

Merged
nturinski merged 2 commits into
mainfrom
copilot/fix-user-assigned-identity-icon
May 20, 2026
Merged

Fix missing icons for role assignment scope nodes under User Assigned Identities#5020
nturinski merged 2 commits into
mainfrom
copilot/fix-user-assigned-identity-icon

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

RoleDefinitionsTreeItem (from @microsoft/vscode-azext-azureutils) resolves Azure resource icons via getAzureIconPath(), which at runtime looks for files under dist/node_modules/@microsoft/vscode-azext-azureutils/resources/azureIcons/. The default esbuild config from @microsoft/vscode-azext-eng only copies root-level SVGs (resources/*.svg) — the azureIcons/ subdirectory was never copied, so all resource-type icons (e.g. StorageAccounts.svg) were missing at runtime.

Changes

  • esbuild.mjs: Extends the default build config to add an esbuild-plugin-copy step that copies resources/azureIcons/*.svg from @microsoft/vscode-azext-azureutils into the correct path under dist/. The package is already a transitive dev dependency via @microsoft/vscode-azext-eng.
configs.extensionConfig = {
    ...configs.extensionConfig,
    plugins: [
        ...(configs.extensionConfig.plugins ?? []),
        copy({
            assets: [{
                from: './node_modules/@microsoft/vscode-azext-azureutils/resources/azureIcons/*.svg',
                to: './node_modules/@microsoft/vscode-azext-azureutils/resources/azureIcons',
            }],
        }),
    ],
};

Copilot AI self-assigned this May 13, 2026
Copilot AI review requested due to automatic review settings May 13, 2026 18:18
Copilot AI review requested due to automatic review settings May 13, 2026 18:18
Copilot AI requested review from Copilot and removed request for Copilot May 13, 2026 18:28
Copilot AI changed the title [WIP] Fix missing icon for User Assigned Identity node in Azure Functions extension Fix missing icons for role assignment scope nodes under User Assigned Identities May 13, 2026
Copilot AI requested a review from nturinski May 13, 2026 18:29
@nturinski nturinski marked this pull request as ready for review May 18, 2026 22:47
@nturinski nturinski requested a review from a team as a code owner May 18, 2026 22:47
Copilot AI review requested due to automatic review settings May 18, 2026 22:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes missing Azure resource-type icons at runtime by ensuring the @microsoft/vscode-azext-azureutils resources/azureIcons/ SVGs are copied into the built dist/ output where getAzureIconPath() expects them.

Changes:

  • Extends the selected esbuild config to include an esbuild-plugin-copy step.
  • Copies @microsoft/vscode-azext-azureutils/resources/azureIcons/*.svg into dist/node_modules/@microsoft/vscode-azext-azureutils/resources/azureIcons during builds.

@nturinski
Copy link
Copy Markdown
Member

image Confirmed that it is showing up now

@nturinski nturinski merged commit 0d21cf0 into main May 20, 2026
3 checks passed
@nturinski nturinski deleted the copilot/fix-user-assigned-identity-icon branch May 20, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing icon for User Assigned Identity node in Azure Functions extension tree view

4 participants