Add support for running glb-director on ubuntu noble#181
Draft
mpenny-github wants to merge 74 commits into
Draft
Add support for running glb-director on ubuntu noble#181mpenny-github wants to merge 74 commits into
mpenny-github wants to merge 74 commits into
Conversation
fjaeckel
reviewed
Apr 1, 2026
|
|
||
| begin_fold "Preparing Docker build environment" | ||
| ( | ||
| docker build -t glb-director-build-noble -f script/Dockerfile.noble script |
Contributor
There was a problem hiding this comment.
Suggested change
| docker build -t glb-director-build-noble -f script/Dockerfile.noble script | |
| docker build -t glb-director-build -f script/Dockerfile.noble script |
instead of copying the whole script, can we please move towards a parameterized version of it to pass the OS flavor as a argument and make this more dynamic?
fjaeckel
requested changes
Apr 1, 2026
Contributor
fjaeckel
left a comment
fjaeckel
left a comment
There was a problem hiding this comment.
please move towards a parameterised version of cibuild for choosing the OS flavor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…nto mpenny_noble_build
Make 'script/cibuild-create-packages focal' and 'script/cibuild-create-packages noble' both succeed by adding compatibility shims for DPDK 23.11 (Noble) while keeping the existing DPDK 17.11 (Focal) build working. Build system: - src/glb-director/Makefile: detect the legacy DPDK make fragments; when absent (Noble), fall back to a pkg-config based build that produces build/app/glb-director. - src/glb-redirect/Makefile: detect /etc/dkms/template-dkms-mkdeb at runtime. On Focal use the legacy 'dkms mkdeb --source-only' path. On Noble dispatch to a new mkdeb-dh-dkms target that synthesises a minimal debian/ tree (control, changelog, rules, source/format, .dkms, .install) and runs dpkg-buildpackage with dh-dkms, producing the same glb-redirect-iptables-dkms_<ver>_all.deb artifact. - script/Dockerfile.noble: add dh-dkms, dpkg-dev, and fakeroot for the modern packaging path. DPDK 23.11 source compatibility: - main.c: gate <rte_kni.h> with __has_include; switch rte_eth_dev_count() to GLB_ETH_DEV_COUNT(); guard pre-22.11 rxmode fields (header_split / hw_ip_checksum / hw_vlan_filter / jumbo_frame / hw_strip_crc) with RTE_VERSION; define and register glb_mbuf_userdata_offset when GLB_HAVE_MBUF_USERDATA_DYNFIELD is set. - glb_kni.c: gate the whole file on GLB_HAVE_KNI (KNI was removed in DPDK 23.11) and provide no-op stubs for the public glb_kni_* API in the disabled branch. - bind_classifier.c: include config.h before bind_classifier_rules.h so the ipv4_hdr/ipv6_hdr -> rte_* aliases are visible to the rule table definitions. - cmdline_parse.c: introduce CMDLINE_CTX() macro to use cmdline_get_ctx() on DPDK >= 22.11 (struct cmdline became opaque). C hygiene fixes surfaced by newer toolchain: - log.h: add include guard and change 'bool debug;' to extern; the single definition now lives in shared_opt.c. Fixes multiple- definition link errors on newer GCC defaults (-fno-common). - strlcpy.h: add header guard to prevent the static inline strlcpy from being declared twice when included via multiple paths. Both 'script/cibuild-create-packages focal' and 'script/cibuild-create-packages noble' now exit 0 and produce the expected .deb artifacts (glb-director-cli, glb-director, glb-director- xdp, xdp-root-shim, glb-healthcheck, glb-redirect-iptables-dkms).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change from the PR is to add build and runtime support for glb-director on ubuntu noble.
The existing test suite is designed to run on a vagrant VM. This PR also updates the test suite to run inside a docker container on github actions.