[Feature] Set CURLSSLOPT_REVOKE_BEST_EFFORT#3831
Open
kai-ion wants to merge 6 commits into
Open
Conversation
sbiscigl
reviewed
May 20, 2026
| bool verifySSL = true; | ||
| /** | ||
| * If set to true, the SDK will not fail SSL connections when Certificate Revocation | ||
| * List (CRL) servers are unreachable. Only applies on Windows when using the curl |
Collaborator
There was a problem hiding this comment.
Only applies on Windows when using the curl HTTP client with Schannel
this is flat out untrue, this configuration is only for setting CURLSSLOPT_REVOKE_BEST_EFFORT update the documentation to reflect this.
additionally we have configuration for specifically windows http we should likely have one for curl if one doesnt already exist and this should be a configuration in there.
| * List (CRL) servers are unreachable. Only applies on Windows when using the curl | ||
| * HTTP client with Schannel. Off by default to maintain strict revocation checking. | ||
| */ | ||
| bool allowCrlOffline = false; |
Collaborator
There was a problem hiding this comment.
why is this called allowCrlOffline, it has to do with CURLSSLOPT_REVOKE_BEST_EFFORT, this should be named to reflect
| curl_easy_setopt(connectionHandle, CURLOPT_SSL_OPTIONS, CURLSSLOPT_REVOKE_BEST_EFFORT); | ||
| } | ||
| #else | ||
| AWS_UNREFERENCED_PARAM(m_allowCrlOffline); |
Collaborator
There was a problem hiding this comment.
this is a member variable, not a parameter why are we using AWS_UNREFERENCED_PARAM?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set CURLSSLOPT_REVOKE_BEST_EFFORT
Issue #, if available:
#3830
Description of changes:
Add CURLSSLOPT_REVOKE_BEST_EFFORT in CurlHttpClient.cpp
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.