Testing improvement parse template variables error paths 17101274120244626605#224
Open
Pet3cy wants to merge 16 commits into
Conversation
Expanded the list of sensitive patterns to include 'credential', 'bearer', 'cookie', and 'session' to prevent accidental exposure of sensitive information in debug logs. Added a test case to verify the new patterns.
Optimize the `executeToolCalls` function by using `Promise.all` to run independent tool calls concurrently instead of sequentially. This significantly reduces the total execution time when multiple tools are invoked in a single response. Benchmark results for 5 tool calls (100ms latency each): - Sequential: ~500ms - Concurrent: ~100ms (~80% improvement)
…892753626 ⚡ execute GitHub MCP tool calls concurrently
Replace sequential for...of loop with Promise.all() for parallel execution of tool calls. This significantly reduces total latency when multiple tools are called.
…452973681 ⚡ Parallelize MCP tool calls
…76531259844171290 🔒 [security fix] Enhance sensitive header masking patterns
- Add test for invalid JSON string response in chatCompletion - Add test for unexpected response shape (missing choices) in chatCompletion - Use regex for JSON parse error matching to support multiple Node versions Co-authored-by: Pet3cy <169947521+Pet3cy@users.noreply.github.com>
Co-authored-by: Pet3cy <169947521+Pet3cy@users.noreply.github.com>
* ⚡ Optimize file loading by making parseFileTemplateVariables async Co-authored-by: Pet3cy <169947521+Pet3cy@users.noreply.github.com> * Update parseFileTemplateVariables tests for async API --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🎯 What: Added test coverage for invalid message roles and missing 'messages' array in prompt YAML files. 📊 Coverage: Added two new prompt fixtures (missing-messages.prompt.yml, invalid-role.prompt.yml) and verified error throwing behavior in loadPromptFile. ✨ Result: Ensured that structural and content validations within the loadPromptFile function are robust and function as expected. Co-authored-by: Pet3cy <169947521+Pet3cy@users.noreply.github.com>
🧪 [Testing Improvement] Add tests for invalid message role and missing messages array
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…336637978605 🧪 [testing improvement] Test error paths in chat completion
- Verify that error messages are correctly wrapped with 'Failed to parse template variables:' prefix. - Add test case for when YAML input is not an object. - Add test case for invalid YAML in parseFileTemplateVariables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.